Share page-check helpers in tests/page_check_common.py

MODES, TEST_FILL, FAKE_BRIDGE, the stub loader, the page opener and the no-AI case list now live in one place; sample_data and push move to tests/conftest.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tests/page_check/conftest.py

@@ -6,42 +6,17 @@ no-AI template is filled with TEST_FILL. Every test runs in light, dark and narr
 The page sees a fake Qt bridge: each slot call lands in window.__calls as [slot, ...args].
 PAGE_CHECK_WIRED=1: the page is wired to a bot (SAMPLE_DATA off), so sample-data cases skip.
 PAGE_CHECK_REPLAY: a JSON-lines file of envelopes a real bot run produced (bot_runner.py's dry run).
+Shared helpers (modes, fill, fake bridge, page opener): tests/page_check_common.py.
 """
-import json
 import os
 import re
 from pathlib import Path
 
 import pytest
+from page_check_common import FAKE_BRIDGE, MODES, TEST_FILL, WIRED, open_page
 
 ROOT = Path(__file__).resolve().parents[2]
 TEMPLATE = ROOT / "rpa-dashboard-no-ai" / "templates" / "dashboard.html"
-TEST_FILL = {
-    "APP_NAME": "Test Bot",
-    "APP_SUBTITLE": "Page check",
-    "LOGO_SRC": "",
-    "API_BASE": "",
-    "STEPS_JSON": json.dumps(["Initializing", "Login", "Process items", "Completed"]),
-    "REPORT_COLUMNS_JSON": json.dumps([{"key": "item", "label": "Item"}, {"key": "status", "label": "Status"}]),
-    "CHECKPOINTS_JSON": json.dumps(["Sign in", "Open the list", "Process items", "Finish up"]),
-}
-FAKE_BRIDGE = """
-window.__calls = [];
-window.qt = {webChannelTransport: {}};
-window.QWebChannel = function (_transport, ready) {
-  const pyBridge = new Proxy({}, {get: (_o, slot) => (...args) => { window.__calls.push([slot, ...args]); }});
-  ready({objects: {pyBridge}});
-};
-"""
-MODES = {"light": (1280, 820, False), "dark": (1280, 820, True), "narrow": (800, 900, False)}
-WIRED = os.environ.get("PAGE_CHECK_WIRED") == "1"
-
-
-@pytest.fixture
-def sample_data():
-    """Use on cases that need the built-in sample data; they skip on a bot-wired page."""
-    if WIRED:
-        pytest.skip("page is wired to a bot, so it has no sample data")
 
 
 @pytest.fixture(scope="session")
@@ -58,28 +33,4 @@ def page_url(tmp_path_factory):
 
 @pytest.fixture(params=list(MODES))
 def page(request, browser, page_url):
-    width, height, dark = MODES[request.param]
-    ctx = browser.new_context(viewport={"width": width, "height": height})
-    ctx.add_init_script(FAKE_BRIDGE)
-    pg = ctx.new_page()
-    pg.set_default_timeout(5000)
-    errors = []
-    pg.on("pageerror", lambda e: errors.append(e))
-    pg.goto(page_url)
-    assert not errors, f"page script errors: {errors}"
-    if pg.get_by_role("form", name="Sign in").is_visible():  # login page section: the host lets us in
-        push_to(pg, "login_result", {"ok": True})
-    if dark:
-        push_to(pg, "apply_dark", {"on": True})
-    yield pg
-    ctx.close()
-
-
-def push_to(pg, event, data):
-    pg.evaluate("([event, data]) => window.__pyMsg(JSON.stringify({event, data}))", [event, data])
-
-
-@pytest.fixture
-def push(page):
-    """push(event, data): send one contract envelope to the page, as the bot would."""
-    return lambda event, data: push_to(page, event, data)
+    yield from open_page(browser, page_url, request.param, FAKE_BRIDGE)

tests/page_check/test_bot_run.py

@@ -6,7 +6,7 @@ import re
 from pathlib import Path
 
 import pytest
-from conftest import WIRED
+from page_check_common import WIRED
 from playwright.sync_api import expect
 from test_contract import colour_of, kpi, open_tab