Share page-check helpers in tests/page_check_common.py

MODES, TEST_FILL, FAKE_BRIDGE, the stub loader, the page opener and the no-AI case list now live in one place; sample_data and push move to tests/conftest.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tests/page_check_ai/conftest.py

@@ -8,32 +8,23 @@ review state directly through the `stub` fixture.
 
 Contract envelopes go in through window.__pyMsg, as in the no-AI check. Each action
 the page POSTs to {API_BASE}/<slot> is recorded in window.__calls as [slot, ...args].
-Every page test runs in light, dark and narrow mode.
+Every page test runs in light, dark and narrow mode. Shared helpers: tests/page_check_common.py.
 """
 import hashlib
-import importlib.util
-import json
 import os
 import re
 import shutil
 import subprocess
-import sys
 import tempfile
 import threading
 from pathlib import Path
 
 import pytest
+from page_check_common import MODES, TEST_FILL, load_stub, open_page
 
 ROOT = Path(__file__).resolve().parents[2]
 TEMPLATE = ROOT / "rpa-dashboard-ai" / "templates" / "web"
-TEST_FILL = {
-    "APP_NAME": "Test Extractor",
-    "APP_SUBTITLE": "Page check",
-    "LOGO_SRC": "",
-    "API_BASE": "/api",
-    "STEPS_JSON": json.dumps(["Initializing", "Login", "Process items", "Completed"]),
-    "REPORT_COLUMNS_JSON": json.dumps([{"key": "item", "label": "Item"}, {"key": "status", "label": "Status"}]),
-}
+TEST_FILL = {**TEST_FILL, "APP_NAME": "Test Extractor", "API_BASE": "/api"}
 RECORD_ACTIONS = """
 window.__calls = [];
 const realFetch = window.fetch;
@@ -43,17 +34,9 @@ window.fetch = (url, opts = {}) => {
   return realFetch(url, opts);
 };
 """
-MODES = {"light": (1280, 820, False), "dark": (1280, 820, True), "narrow": (800, 900, False)}
 SKIP_COPY = shutil.ignore_patterns("node_modules", "dist", "__pycache__")
 
 
-@pytest.fixture
-def sample_data():
-    """Shared no-AI cases that need the page's own sample data skip on a bot-wired page."""
-    if os.environ.get("PAGE_CHECK_WIRED") == "1":
-        pytest.skip("page is wired to a bot, so it has no sample data")
-
-
 @pytest.fixture(scope="session")
 def site():
     """The dashboard folder under test: server_stub.py, index.html and the sources."""
@@ -81,11 +64,7 @@ def built(site):
 
 @pytest.fixture(scope="session")
 def stub_module(site):
-    sys.path.insert(0, str(site))  # the stub imports bands.py from its own folder
-    spec = importlib.util.spec_from_file_location("server_stub", site / "server_stub.py")
-    mod = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(mod)
-    return mod
+    return load_stub(site)
 
 
 @pytest.fixture(scope="session")
@@ -110,26 +89,4 @@ def page_url(built, server):
 
 @pytest.fixture(params=list(MODES))
 def page(request, browser, page_url, stub):
-    width, height, dark = MODES[request.param]
-    ctx = browser.new_context(viewport={"width": width, "height": height})
-    ctx.add_init_script(RECORD_ACTIONS)
-    pg = ctx.new_page()
-    pg.set_default_timeout(5000)
-    errors = []
-    pg.on("pageerror", lambda e: errors.append(e))
-    pg.goto(page_url)
-    assert not errors, f"page script errors: {errors}"
-    if dark:
-        push_to(pg, "apply_dark", {"on": True})
-    yield pg
-    ctx.close()
-
-
-def push_to(pg, event, data):
-    pg.evaluate("([event, data]) => window.__pyMsg(JSON.stringify({event, data}))", [event, data])
-
-
-@pytest.fixture
-def push(page):
-    """push(event, data): send one contract envelope to the page, as the bot would."""
-    return lambda event, data: push_to(page, event, data)
+    yield from open_page(browser, page_url, request.param, RECORD_ACTIONS)

tests/page_check_ai/test_ai_shared.py

@@ -2,18 +2,6 @@
 
 They use this folder's `page` and `push` fixtures, so they check the React page.
 """
-import sys
-from pathlib import Path
+from page_check_common import no_ai_cases
 
-sys.path.insert(0, str(Path(__file__).resolve().parents[1] / "page_check"))
-
-from test_contract import (  # noqa: E402,F401
-    test_dark_toggle_flips_theme,
-    test_donut_and_legend_match_batch_states,
-    test_kpi_counts_match_batch_states,
-    test_log_lines_show_their_type,
-    test_no_bot_page_runs_on_sample_data,
-    test_plain_browser_first_open_shows_sample_data,
-    test_report_search_filters_rows_and_shows_bucket_pill,
-    test_step_list_follows_step_label,
-)
+globals().update(no_ai_cases())